kernel: Add cmdline to the built artifacts #41
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foersleo
approved these changes
Feb 7, 2025
|
Can you please open an issue for reviewing the cmdline options. Maybe also mention that these cmdline options are coming from https://github.com/aws/aws-nitro-enclaves-cli/blob/main/blobs/aarch64/cmdline and https://github.com/aws/aws-nitro-enclaves-cli/blob/main/blobs/x86_64/cmdline |
meerd
approved these changes
Feb 7, 2025
atanzu
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
This PR adds the kernel command line parameters to the built artifacts for the Nitro Enclaves kernel. Specifically, it includes the
aarch64.cmdlineandx86_64.cmdlinefiles.As discussed with @foersleo , we may need to further investigate whether these parameters should be kept as-is or modified for each architecture.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.